Skip to content

We should ./x check --stage=0 in CI to make sure people don't forget to cfg(bootstrap)/cfg(not(bootstrap)) #141905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jieyouxu opened this issue Jun 2, 2025 · 0 comments · Fixed by #141914
Closed

We should ./x check --stage=0 in CI to make sure people don't forget to cfg(bootstrap)/cfg(not(bootstrap)) #141905

jieyouxu opened this issue Jun 2, 2025 · 0 comments · Fixed by #141914
Labels
A-CI Area: Our Github Actions CI C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jun 2, 2025

No description provided.

@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-CI Area: Our Github Actions CI labels Jun 2, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 2, 2025
@jieyouxu jieyouxu mentioned this issue Jun 2, 2025
Closed
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 2, 2025
@onur-ozkan onur-ozkan mentioned this issue Jun 2, 2025
Merged
@fmease fmease changed the title We should ./x check stage=0 in CI to make sure people don't forget to cfg(bootstrap)/cfg(not(bootstrap)) We should ./x check --stage=0 in CI to make sure people don't forget to cfg(bootstrap)/cfg(not(bootstrap)) Jun 2, 2025
@bors bors closed this as completed in 72f60fb Jun 3, 2025
rust-timer added a commit that referenced this issue Jun 3, 2025
@rust-timer
Unrolled build for #141914
7bea91f 
Rollup merge of #141914 - onur-ozkan:follow-ups, r=Kobzol

redesign stage 0 std follow-ups

Various follow-ups pointed out on Zulip during post-merge discussions of [redesign stage 0 std #119899](#119899).

r? `@jieyouxu`

Fixes #141902.
Fixes #141905.

cc `@jyn514`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Area: Our Github Actions CI C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redesign stage 0 std follow-ups onur-ozkan/rust
2 participants
@jieyouxu @rustbot