Skip to content

Unify formatting floats and f{32,64}::to_str_digits #15432

Closed
@erickt

Description

@erickt
Contributor

cc @alexcrichton. It looks like we have a lot of duplicated code with libcore/fmt/float.rs and std::num::strconv::float_to_str_bytes_common. Can this code be merged?

Activity

alexcrichton

alexcrichton commented on Jul 5, 2014

@alexcrichton
Member

I'd love to remove the libstd version! I think that it did a thing or two that the libcore version didn't do (hence the duplication), but those bits could probably just be removed.

steveklabnik

steveklabnik commented on Jun 29, 2015

@steveklabnik
Member

I'm not sure how this has gottne shuffled, but to_str_digits nor most of these modules still exist. Let me know if this refactor is still worthwhile!

added a commit that references this issue on Nov 13, 2023

Auto merge of rust-lang#15432 - alibektas:deunwrap/inline_call, r=Vey…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @steveklabnik@alexcrichton@erickt

        Issue actions

          Unify formatting floats and f{32,64}::to_str_digits · Issue #15432 · rust-lang/rust