Skip to content

Use serialisation for save_analysis #18582

Closed
@nrc

Description

@nrc
Member

Currently we use an ad hoc csv format for dumping analysis data (see rustc::middle::save::recorder). It would be better to use libserialize (or serde) for the dumping step so we can easily provide data in different formats.

By default, I think save_analysis should output JSON, since that seems to be the current hotness for this sort of thing.

I expect this to be not too hard, but non-trivial, and possibly a little bit tedious.

Activity

added
E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
on Nov 3, 2014
sinistersnare

sinistersnare commented on Nov 3, 2014

@sinistersnare
Contributor

cc me

gamazeps

gamazeps commented on Nov 4, 2014

@gamazeps
Contributor

Willing to work on this too :)

gamazeps

gamazeps commented on Nov 5, 2014

@gamazeps
Contributor

@sinistersnare Wanna split the work ? Or did you cc just in order to see the progress ?

sinistersnare

sinistersnare commented on Nov 6, 2014

@sinistersnare
Contributor

Sure. this could be interesting.

rolandshoemaker

rolandshoemaker commented on Jan 6, 2015

@rolandshoemaker

Is this still being worked on or abandoned?

nrc

nrc commented on Jan 6, 2015

@nrc
MemberAuthor

@sinistersnare @gamazeps ? (See previous comment)

sinistersnare

sinistersnare commented on Jan 7, 2015

@sinistersnare
Contributor

Oh goodness, I forgot about this :)

I can start work on this next week, but if you want to take this @rolandshoemaker, than feel free. Sorry!

Potpourri

Potpourri commented on Feb 3, 2015

@Potpourri
Contributor

I would like to work on this.

sinistersnare

sinistersnare commented on Feb 3, 2015

@sinistersnare
Contributor

Please do, I have no more plans of contributing.

Potpourri

Potpourri commented on Feb 5, 2015

@Potpourri
Contributor

@nick29581 Do I need to keep csv support?

nrc

nrc commented on Feb 5, 2015

@nrc
MemberAuthor

@Potpourri tl;dr: no.

What would be ideal would be to have a generic serialisation API which could serialise to JSON, CSV or whatever else. I'm not sure if that is possible or how easy it is (@erickt might be able to advise). I'd be pretty happy with just JSON, as long as it wasn't too hard-wired in. (You could also earn mega-love from me by converting DXR to understand JSON rather than CSV as a follow up, but I'm also happy to do that).

steveklabnik

steveklabnik commented on Mar 4, 2016

@steveklabnik
Member

Triage: looks like we're still using the CSV format.

17 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-feature-requestCategory: A feature request, i.e: not implemented / a PR.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @steveklabnik@alexcrichton@nrc@Potpourri@tamird

        Issue actions

          Use serialisation for save_analysis · Issue #18582 · rust-lang/rust