You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'll look into the comparison traits, which seems like one of the few things currently actionable. (Anything that needs associated types is blocked on #18594, #19129, etc)
@gankro I think that @japaric is right in that the entire RFC isn't necessarily actionable right now, but I do think that we should try to implement as much as possible in the meantime. Just knowing the list of blockers would be helpful!
I think that another actionable item is changing Add et al. from by-ref to by-value.
Agreed. That will likely need to be coordinated with language changes, since currently & is implicitly added to the arguments. @nikomatsakis was working recently in this area and could probably help guide the staging.
On Fri, Nov 21, 2014 at 08:53:05AM -0800, Aaron Turon wrote:
Agreed. That will likely need to be coordinated with language
changes, since currently & is implicitly added to the
arguments. @nikomatsakis was working recently in this area and could
probably help guide the staging.
Hmm. Yes, ping me, or I can try to get started on this. Sorry for the
delay, way behind on github mail.
I think that another actionable item is changing Add et al. from by-ref to by-value.
I'll look into this during this week. I'm now somewhat familiar with this part of the compiler, and this looks doable now. I'll ping @nikomatsakis on IRC if I find any issue that I can't sort out.
@AndyShiue from the top of my head, as per the RFC the index(&self, &Index) method needs to take the Index parameter by value instead of by reference. And @nick29581 is unifying the slicing/indexing operators under the Index trait.
Activity
Gankra commentedon Nov 20, 2014
What's the implementation plan?
japaric commentedon Nov 20, 2014
I'll look into the comparison traits, which seems like one of the few things currently actionable. (Anything that needs associated types is blocked on #18594, #19129, etc)
alexcrichton commentedon Nov 20, 2014
@gankro I think that @japaric is right in that the entire RFC isn't necessarily actionable right now, but I do think that we should try to implement as much as possible in the meantime. Just knowing the list of blockers would be helpful!
aturon commentedon Nov 20, 2014
Nominating P-backcompat-lang 1.0 (though we may want to triage parts of this separately.)
japaric commentedon Nov 21, 2014
I think that another actionable item is changing
Add
et al. from by-ref to by-value.aturon commentedon Nov 21, 2014
@japaric
Agreed. That will likely need to be coordinated with language changes, since currently
&
is implicitly added to the arguments. @nikomatsakis was working recently in this area and could probably help guide the staging.nikomatsakis commentedon Nov 27, 2014
On Fri, Nov 21, 2014 at 08:53:05AM -0800, Aaron Turon wrote:
Hmm. Yes, ping me, or I can try to get started on this. Sorry for the
delay, way behind on github mail.
japaric commentedon Dec 1, 2014
I'll look into this during this week. I'm now somewhat familiar with this part of the compiler, and this looks doable now. I'll ping @nikomatsakis on IRC if I find any issue that I can't sort out.
auto merge of #19167 : japaric/rust/rhs-cmp, r=aturon
5 remaining items
auto merge of #19448 : japaric/rust/binops-by-value, r=nikomatsakis
AndyShiue commentedon Jan 4, 2015
All done?
japaric commentedon Jan 4, 2015
@AndyShiue from the top of my head, as per the RFC the
index(&self, &Index)
method needs to take theIndex
parameter by value instead of by reference. And @nick29581 is unifying the slicing/indexing operators under theIndex
trait.aturon commentedon Jan 8, 2015
Nominating to move to -beta milestone.
pnkfelix commentedon Jan 8, 2015
Assigning 1.0-beta milestone.
Merge pull request rust-lang#19148 from Veykril/push-ptnykrwnwwlu