Skip to content

Implement cmp and ops reform #19148

@alexcrichton

Description

@alexcrichton
Member

Tracking issue for rust-lang/rfcs#439

Activity

Gankra

Gankra commented on Nov 20, 2014

@Gankra
Contributor

What's the implementation plan?

japaric

japaric commented on Nov 20, 2014

@japaric
Member

I'll look into the comparison traits, which seems like one of the few things currently actionable. (Anything that needs associated types is blocked on #18594, #19129, etc)

alexcrichton

alexcrichton commented on Nov 20, 2014

@alexcrichton
MemberAuthor

@gankro I think that @japaric is right in that the entire RFC isn't necessarily actionable right now, but I do think that we should try to implement as much as possible in the meantime. Just knowing the list of blockers would be helpful!

aturon

aturon commented on Nov 20, 2014

@aturon
Member

Nominating P-backcompat-lang 1.0 (though we may want to triage parts of this separately.)

japaric

japaric commented on Nov 21, 2014

@japaric
Member

I think that another actionable item is changing Add et al. from by-ref to by-value.

aturon

aturon commented on Nov 21, 2014

@aturon
Member

@japaric

I think that another actionable item is changing Add et al. from by-ref to by-value.

Agreed. That will likely need to be coordinated with language changes, since currently & is implicitly added to the arguments. @nikomatsakis was working recently in this area and could probably help guide the staging.

nikomatsakis

nikomatsakis commented on Nov 27, 2014

@nikomatsakis
Contributor

On Fri, Nov 21, 2014 at 08:53:05AM -0800, Aaron Turon wrote:

Agreed. That will likely need to be coordinated with language
changes, since currently & is implicitly added to the
arguments. @nikomatsakis was working recently in this area and could
probably help guide the staging.

Hmm. Yes, ping me, or I can try to get started on this. Sorry for the
delay, way behind on github mail.

japaric

japaric commented on Dec 1, 2014

@japaric
Member

I think that another actionable item is changing Add et al. from by-ref to by-value.

I'll look into this during this week. I'm now somewhat familiar with this part of the compiler, and this looks doable now. I'll ping @nikomatsakis on IRC if I find any issue that I can't sort out.

added a commit that references this issue on Dec 4, 2014

5 remaining items

added a commit that references this issue on Dec 15, 2014
AndyShiue

AndyShiue commented on Jan 4, 2015

@AndyShiue

All done?

japaric

japaric commented on Jan 4, 2015

@japaric
Member

@AndyShiue from the top of my head, as per the RFC the index(&self, &Index) method needs to take the Index parameter by value instead of by reference. And @nick29581 is unifying the slicing/indexing operators under the Index trait.

aturon

aturon commented on Jan 8, 2015

@aturon
Member

Nominating to move to -beta milestone.

pnkfelix

pnkfelix commented on Jan 8, 2015

@pnkfelix
Member

Assigning 1.0-beta milestone.

modified the milestones: 1.0 beta, 1.0 on Jan 8, 2015
added a commit that references this issue on Feb 17, 2025
caa651a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @alexcrichton@brson@nikomatsakis@pnkfelix@aturon

      Issue actions

        Implement cmp and ops reform · Issue #19148 · rust-lang/rust