You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ah, yep. Didn't even see this issue! After #19472 makes it into a snapshot, my PR should close this issue. I'll make double sure before then that I'm getting all of them.
Oops, looks like the two in borrowck were added after my PR was r+'ed and I didn't see them. I'd be happy to go take them out, but it looks like #19741 actually takes care of these last three as part of the second commit, so it may potentially be better to just wait for that to land so I don't get in the way of it.
Activity
abonander commentedon Dec 4, 2014
Looks like most of the work has been done in #19517
csouth3 commentedon Dec 4, 2014
Ah, yep. Didn't even see this issue! After #19472 makes it into a snapshot, my PR should close this issue. I'll make double sure before then that I'm getting all of them.
if_let
,while_let
, ortuple_indexing
anymore. #19517if_let
,while_let
, andtuple_indexing
. #19763mdinger commentedon Dec 12, 2014
You'll want to remove them from the list of compiler features as well
csouth3 commentedon Dec 12, 2014
Pull request has been updated, thanks!
rollup merge of rust-lang#19763: csouth3/remove-featuregates
rollup merge of rust-lang#19763: csouth3/remove-featuregates
lgrz commentedon Dec 15, 2014
These feature gates (
if_let
,tuple_indexing
) look liked they were left in, they're supposed to be removed right?https://github.com/rust-lang/rust/blob/master/src/libcollections/lib.rs#L27
https://github.com/rust-lang/rust/blob/master/src/librustc_borrowck/lib.rs#L19-L20
csouth3 commentedon Dec 15, 2014
Oops, looks like the two in borrowck were added after my PR was r+'ed and I didn't see them. I'd be happy to go take them out, but it looks like #19741 actually takes care of these last three as part of the second commit, so it may potentially be better to just wait for that to land so I don't get in the way of it.
lgrz commentedon Dec 15, 2014
Ah thanks, I wasn't aware they were already taken care of.
rollup merge of rust-lang#19763: csouth3/remove-featuregates
1 remaining item