Skip to content

Remove #![feature()] for if_let, while_let, and tuple_indexing #19473

Closed
@nrc

Description

@nrc
Member

Needs a snapshot after #19472 lands

Activity

added
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
on Dec 2, 2014
abonander

abonander commented on Dec 4, 2014

@abonander
Contributor

Looks like most of the work has been done in #19517

csouth3

csouth3 commented on Dec 4, 2014

@csouth3
Contributor

Ah, yep. Didn't even see this issue! After #19472 makes it into a snapshot, my PR should close this issue. I'll make double sure before then that I'm getting all of them.

mdinger

mdinger commented on Dec 12, 2014

@mdinger
Contributor

You'll want to remove them from the list of compiler features as well

csouth3

csouth3 commented on Dec 12, 2014

@csouth3
Contributor

Pull request has been updated, thanks!

added 4 commits that reference this issue on Dec 12, 2014

rollup merge of rust-lang#19763: csouth3/remove-featuregates

e3638d3

rollup merge of rust-lang#19763: csouth3/remove-featuregates

a2bf4de
lgrz

lgrz commented on Dec 15, 2014

@lgrz
Contributor
csouth3

csouth3 commented on Dec 15, 2014

@csouth3
Contributor

Oops, looks like the two in borrowck were added after my PR was r+'ed and I didn't see them. I'd be happy to go take them out, but it looks like #19741 actually takes care of these last three as part of the second commit, so it may potentially be better to just wait for that to land so I don't get in the way of it.

lgrz

lgrz commented on Dec 15, 2014

@lgrz
Contributor

Ah thanks, I wasn't aware they were already taken care of.

added a commit that references this issue on Dec 15, 2014

rollup merge of rust-lang#19763: csouth3/remove-featuregates

e717362

1 remaining item

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @lgrz@nrc@abonander@mdinger@csouth3

      Issue actions

        Remove #![feature()] for if_let, while_let, and tuple_indexing · Issue #19473 · rust-lang/rust