Skip to content

make tidy should require an issue number in FIXMEs #19546

Closed
@nrc

Description

@nrc
Member

We used to do this and it was annoying, but it is more annoying not to have it. Let's reinstate it!

Activity

nikomatsakis

nikomatsakis commented on Dec 5, 2014

@nikomatsakis
Contributor

cc me

Gankra

Gankra commented on Dec 5, 2014

@Gankra
Contributor

There's a few FIXME's in libcollections that amount to "Future optimization/design work" that don't super make sense to have issues logged against them. I guess we could have a misc "make stuff better" bug.

nrc

nrc commented on Dec 16, 2014

@nrc
MemberAuthor

We discussed this at the weekly meeting, and whilst we think we could do something better, requiring issue numbers when we haven't would be too much work and mean coming up with a lot of pointless issues. Reviewers should encourage issue numbers in FIXMEs, but we won't change make tidy for now.

pnkfelix

pnkfelix commented on Dec 17, 2018

@pnkfelix
Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @nikomatsakis@pnkfelix@nrc@Gankra

        Issue actions

          make tidy should require an issue number in FIXMEs · Issue #19546 · rust-lang/rust