Closed
Description
I've jumped through hoops a few times trying to write use statements conditionalized by platform.
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
{{ message }}
No one assigned
No type
No projects
No milestone
None yet
Activity
brson commentedon May 5, 2012
I've changed my mind about this.
marijnh commentedon May 8, 2012
Why? With this issue in mind, I just implemented attributes for view items (I was messing with the view item parsing code anyway to add support for pub imports). But supporting conditional compilation for view items seems like a no-brainer -- it's useful, and unproblematic.
brson commentedon May 8, 2012
I only changed my mind because I had a reasonable workaround and didn't want to bother with an RFC.
Support visibility modifiers and attributes on view items
graydon commentedon May 9, 2012
Yeah, it seems reasonable to me too.
jdm commentedon Jul 9, 2012
Is this complete, or is conditional compilation still required?
brson commentedon Jul 9, 2012
The configuration (conditional compilation) pass still ignores view item attributes.
rustc: Conditionally compile view items. #2357
brson commentedon Jul 9, 2012
Fixed.
Auto merge of rust-lang#2357 - DebugSteven:epoll_create1-shim, r=oli-obk
Auto merge of rust-lang#2357 - DebugSteven:epoll_create1-shim, r=oli-obk
Merge pull request rust-lang#2357 from mejrs/diag