Skip to content

Ampersands in documentation are drawn incorrectly in some browser configurations #24355

@nstoddard

Description

@nstoddard

On my system, ampersands in the documentation are drawn incorrectly in Chrome: https://i.imgur.com/FmG93G5.png. I'm using Windows 7, 64-bit. This doesn't happen in Firefox.

I'm thinking this could be a bug in Chrome, but I haven't seen it on any other site. It seems to happen on any page generated with rustdoc. Ampersands in the examples aren't affected.

Activity

nstoddard

nstoddard commented on Apr 12, 2015

@nstoddard
Author

It looks like this is similar to #16372. I deleted the Source Code Pro font, which fixed it. Since I'm at least the second person to come across this issue, maybe we should try to find a more permanent solution. Is it possible for rustdoc to automatically download and use the most recent version of the font? If not, maybe this issue should at least be documented somewhere.

I'm still not sure why this issue was happening in Chrome but not Firefox.

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Apr 13, 2015
killercup

killercup commented on Apr 13, 2015

@killercup
Member

Is there a reason why for the Source (\w*) Pro fonts the locally installed version is requested first, but not for Fira Sans (cf. rustdoc's main.css)? Are there many people who have those installed? (Even then, why not give Fira the same chance?)

If we are concerned about file sizes or compatibility, we should probably add woff2 (newer, smaller format) and eot (legacy IE format) versions of the fonts.

ZobyTwo

ZobyTwo commented on May 9, 2015

@ZobyTwo

I dont have any of those fonts installed and still have the same issue (windows, chrome). I found (https://code.google.com/p/googlefontdirectory/issues/detail?id=178) which suggests that there is a newer version of the font which might fix the problem.

azerupi

azerupi commented on Jun 29, 2015

@azerupi
Contributor

It may be a good idea to use a CDN for the font's (like Google font) with a local fallback when the CDN can't be reached, for example when offline. This has a couple of advantages

  • loading the latest version from the CDN
  • parallel http request and thus faster load times
  • if the font from the CDN has been loaded on another page, it will be cached and thus speed up the page load too.

It might be interesting to do that for jQuery too since it is the most downloaded js library there is a very high probability that it will already be in the browser cache.

jonimake

jonimake commented on Feb 6, 2016

@jonimake

Still happening with Chrome 48.0.2564.103 m and Windows 10.

jonas-schievink

jonas-schievink commented on Mar 12, 2016

@jonas-schievink
Contributor

This is getting pretty annoying now, and this happens on basically the most common Windows configuration (plus, this issue is almost a year old now). Can't we just use another font for now?

ghost

ghost commented on May 26, 2016

@ghost

I have this issue too, fresh Chrome on Win8.1.

I personally use a browser plugin to change the fonts on the documentation pages, but that's not an ideal solution.

Edit: I submitted an issue on this to Google Fonts.

added a commit that references this issue on Jun 6, 2016
sateffen

sateffen commented on Jun 11, 2016

@sateffen

Hey,

I've got the same problem with the ampersands, and it makes the documentation very hard to read. After some time you can get used to it, but at first this not just sucks, it tells me to leave the page and never come back.

The solution to update the font on all of my computers is not acceptable for me. I have 2 win10 and 2 win7 machines having the same problem, all in chrome browser, and to be honest: I don't want to update my computers by hand, just for one website. Even if it's a chrome problem, there is a way to work around that problem.

Why not just remove the font, and use the other ones? DejaVu Sans Mono looks very clean and good, and it's been around for quite some time, so I guess it's glitch free?

10 remaining items

matthew-piziak

matthew-piziak commented on Sep 17, 2016

@matthew-piziak
Contributor

Yep, I'm convinced. 👍

nrc

nrc commented on Sep 20, 2016

@nrc
Member

So looking at Rustdoc's CSS I find this : src: local('Source Code Pro'), url("SourceCodePro-Regular.woff") format('woff'); which seems to imply we'll use the local version of source code pro before the web font version. I think just removing the local clause will force using the web font and thus avoid the buggy old version of the font that some people have on their systems.

Boddlnagg

Boddlnagg commented on Sep 21, 2016

@Boddlnagg
Contributor

I've been affected by this bug multiple times, since something on my machine (Windows) seems to keep reinstalling an old version of Source Code Pro. I haven't been able to figure out what it is. @nrc's fix sounds like the right solution to me.

sourcefrog

sourcefrog commented on Dec 4, 2016

@sourcefrog
Contributor

See also /issues/34681, around a same-origin problem loading fonts from the doc tree on Firefox. It seems like just removing the local clause could make that happen more often?

added a commit that references this issue on Dec 4, 2016
bee82e8
sourcefrog

sourcefrog commented on Dec 4, 2016

@sourcefrog
Contributor

I made the change suggested by @nrc of removing use of the local font in . The results are in https://storage.googleapis.com/mbp-rust-builds/fonts/doc/std/index.html so perhaps people who can reproduce this can try that and report how it looks.

added 2 commits that reference this issue on Dec 12, 2016
37036aa
5e425b7
added a commit that references this issue on Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @killercup@alexcrichton@eternaleye@brson@sourcefrog

        Issue actions

          Ampersands in documentation are drawn incorrectly in some browser configurations · Issue #24355 · rust-lang/rust