Skip to content

Remove #[staged_api] #30008

Closed
Closed
@brson

Description

@brson
Contributor

The only purpose this serves is to make stability attributes modal, distinguishing between in-tree and out-of-tree use cases. #29952 though renamed #[deprecated] to #[rustc_deprecated], so afaik #[staged_api] does nothing useful.

Activity

added
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
on Nov 23, 2015
brson

brson commented on Nov 23, 2015

@brson
ContributorAuthor

Fixing this should be a matter of removing the code that checks it in stability.rs, following the leads to other fallout in the compiler, removing the attribute from all the crates it's attached to.

petrochenkov

petrochenkov commented on Nov 23, 2015

@petrochenkov
Contributor

Hm, what about #[stable] and #[unstable]? They are guarded by #[staged_api] as well.
But they can probably be guarded by #[feature(staged_api)] itself instead.

added
E-help-wantedCall for participation: Help is requested to fix this issue.
and removed
E-help-wantedCall for participation: Help is requested to fix this issue.
on Nov 24, 2015
added a commit that references this issue on Nov 26, 2015

Auto merge of #30015 - petrochenkov:staged, r=brson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @brson@Manishearth@petrochenkov

        Issue actions

          Remove `#[staged_api]` · Issue #30008 · rust-lang/rust