Skip to content

change + mode to pass by-value #3093

Closed
Closed
@nikomatsakis

Description

@nikomatsakis
Contributor

Right now we are using + as the "by value" mode, but in fact at runtime it passes by reference. We should change it to pass by value.

Activity

nikomatsakis

nikomatsakis commented on Aug 2, 2012

@nikomatsakis
ContributorAuthor

assigned to 0.4 milestone as "mode removal" is a big goal

bblum

bblum commented on Aug 3, 2012

@bblum
Contributor

will this affect the semantics of passing @ boxes in +-mode? i wrote TLS with this in mind, and am not sure whether or not it will break if changed.

nikomatsakis

nikomatsakis commented on Aug 3, 2012

@nikomatsakis
ContributorAuthor

this would not affect the semantics, I don't think.

graydon

graydon commented on Mar 25, 2013

@graydon
Contributor

I think this is possibly-done at this point, but someone should confirm.

nikomatsakis

nikomatsakis commented on Mar 29, 2013

@nikomatsakis
ContributorAuthor

This is done.

added a commit that references this issue on May 15, 2021

Merge pull request rust-lang#3093 from scampi/issue2633

2f8c1fe
added 2 commits that reference this issue on Sep 30, 2023

Auto merge of rust-lang#3093 - eduardosm:llvm.x86.sse2.pmadd.wd, r=Ra…

Auto merge of rust-lang#3093 - eduardosm:llvm.x86.sse2.pmadd.wd, r=Ra…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-codegenArea: Code generation

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @graydon@nikomatsakis@bblum

        Issue actions

          change + mode to pass by-value · Issue #3093 · rust-lang/rust