-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Description
I noticed when checking the syntex-syntax
node that, when I add a private fn into the crate module, it invalidates the krate-0 module. This is because the metadata includes edges to the immediate children. This seems bad, but then there is also a read whenever we read an inlined item from crate X of the crate root, which means that this winds up triggering bad reuse. I am trying to figure out why this read arises and remove it, but I'd also like to remove the dependency of metadata.
Metadata
Metadata
Assignees
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Projects
Relationships
Development
Select code repository
Activity
michaelwoerister commentedon Nov 16, 2016
Was this fixed by c6363b8?
nikomatsakis commentedon Nov 21, 2016
@michaelwoerister quite likely; I guess I will make a perf test to check
nikomatsakis commentedon Nov 21, 2016
Looks good. Posted a PR with a test.
add regression test for rust-lang#36168
Rollup merge of rust-lang#37919 - nikomatsakis:incremental-36168, r=mw
Rollup merge of rust-lang#37919 - nikomatsakis:incremental-36168, r=mw