Skip to content

Errant edge to krate node #36168

@nikomatsakis

Description

@nikomatsakis
Contributor

I noticed when checking the syntex-syntax node that, when I add a private fn into the crate module, it invalidates the krate-0 module. This is because the metadata includes edges to the immediate children. This seems bad, but then there is also a read whenever we read an inlined item from crate X of the crate root, which means that this winds up triggering bad reuse. I am trying to figure out why this read arises and remove it, but I'd also like to remove the dependency of metadata.

Activity

added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
A-incr-compArea: Incremental compilation
on Aug 31, 2016
added this to the Incremental compilation alpha milestone on Aug 31, 2016
michaelwoerister

michaelwoerister commented on Nov 16, 2016

@michaelwoerister
Member

Was this fixed by c6363b8?

nikomatsakis

nikomatsakis commented on Nov 21, 2016

@nikomatsakis
ContributorAuthor

@michaelwoerister quite likely; I guess I will make a perf test to check

nikomatsakis

nikomatsakis commented on Nov 21, 2016

@nikomatsakis
ContributorAuthor

Looks good. Posted a PR with a test.

added a commit that references this issue on Dec 1, 2016
added a commit that references this issue on Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-incr-compArea: Incremental compilationT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @nikomatsakis@michaelwoerister

        Issue actions

          Errant edge to krate node · Issue #36168 · rust-lang/rust