Skip to content

Switch the order of pipes::stream's result #3637

Closed
@brson

Description

@brson
Contributor

stream returns (Chan, Port) but I intuitively expect (Port, Chan) (not sure why). I've seen others make this mistake too.

Activity

nikomatsakis

nikomatsakis commented on Oct 2, 2012

@nikomatsakis
Contributor

+1. Somehow "port and channel" sounds right, "channel and port" sounds
backwards.

ben0x539

ben0x539 commented on Oct 4, 2012

@ben0x539
Contributor

The pipe syscall gives you the read end of the pipe first and the write end second, maybe that's why?

BrendanEich

BrendanEich commented on Oct 4, 2012

@BrendanEich

@ben0x539 that's a good reason that Unix nerds like me find compelling, but I think @nikomatsakis is pointing to the poetic win of trochaic PORT and CHANnel vs. the awkwardly inverted foot in CHANnel and PORT.

/be

catamorphism

catamorphism commented on Dec 12, 2012

@catamorphism
Contributor

Done pending review (not that anything needs reviewing, but I wanted to make sure there was really consensus).

catamorphism

catamorphism commented on Dec 12, 2012

@catamorphism
Contributor

Done: 38bd694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ben0x539@brson@nikomatsakis@BrendanEich@catamorphism

        Issue actions

          Switch the order of `pipes::stream`'s result · Issue #3637 · rust-lang/rust