Skip to content

Module level attributes are being parsed before plugins are registered #36617

Closed
@draivin

Description

@draivin

Previously I was using a plugin to register a MultiModifier, and the plugin users would use a #![modifier] attribute in the entry module of their programs, so the plugin could rewrite anything inside the module.

But on the latest nightly, this results in a compilation error:

error: The attribute `modifier` is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642)

This leads me to believe that module level attributes are now being parsed before the plugins finish registering.

Tagging @jseyfried.

Activity

jseyfried

jseyfried commented on Sep 21, 2016

@jseyfried
Contributor

Fixed in #36618 (this was caused by #36214, unintentionally).

added a commit that references this issue on Sep 22, 2016

Auto merge of #36618 - jseyfried:crate_root_attr_invoc, r=nrc

a09cb57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @draivin@jseyfried

        Issue actions

          Module level attributes are being parsed before plugins are registered · Issue #36617 · rust-lang/rust