Skip to content

[src] links in beta and nightly documentation are broken #37684

@RalfJung

Description

@RalfJung
Member

At least some of the [src] links in the beta standard library documentation are currently broken. I tried https://doc.rust-lang.org/beta/std/iter/trait.Iterator.html and https://doc.rust-lang.org/beta/std/iter/trait.IntoIterator.html.

Activity

changed the title [-][src] links in beta documentation are broken[/-] [+][src] links in beta and nightly documentation are broken[/+] on Nov 10, 2016
added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Nov 10, 2016
bluss

bluss commented on Nov 10, 2016

@bluss
Member

Seems to affect some items that libstd reexports from libcore.

alexcrichton

alexcrichton commented on Nov 10, 2016

@alexcrichton
Member

I'd also be interested in investigating why CI isn't catching this...

GuillaumeGomez

GuillaumeGomez commented on Nov 10, 2016

@GuillaumeGomez
Member

The [src] link should be generated based on the "original" item instead of the current one. (spitting out the obvious)

added
regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.
and removed
regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.
on Nov 11, 2016
bluss

bluss commented on Nov 11, 2016

@bluss
Member

Ok, good news, this bug did not migrate to stable when beta did?

alexcrichton

alexcrichton commented on Nov 11, 2016

@alexcrichton
Member

Something looks off-by-one in the gotosrc links (which is why linkchecker didn't catch this). libstd thinks the iterator trait is 3636 and libcore thinks it's 3637. Sounds like the ids used by rustdoc are perhaps no longer valid?

GuillaumeGomez

GuillaumeGomez commented on Nov 11, 2016

@GuillaumeGomez
Member

Taking a look.

added a commit that references this issue on Nov 12, 2016
5dcf0e8
bluss

bluss commented on Nov 12, 2016

@bluss
Member

Thanks for fixing this! rustdoc improvements = ❤️

ollie27

ollie27 commented on Nov 18, 2016

@ollie27
Member

This isn't fixed. See std::str::Chars. The link is https://doc.rust-lang.org/nightly/core/str/struct.Chars.html?gotosrc=42892 but it should be https://doc.rust-lang.org/nightly/core/str/struct.Chars.html?gotosrc=42906. They differ by 14 which is the same number of items with #[cfg(dox)] in src/libcore/macros.rs so I think it's the same issue.

GuillaumeGomez

GuillaumeGomez commented on Nov 18, 2016

@GuillaumeGomez
Member

Taking another look then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @alexcrichton@RalfJung@GuillaumeGomez@bluss@ollie27

      Issue actions

        [src] links in beta and nightly documentation are broken · Issue #37684 · rust-lang/rust