-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Description
At least some of the [src]
links in the beta standard library documentation are currently broken. I tried https://doc.rust-lang.org/beta/std/iter/trait.Iterator.html and https://doc.rust-lang.org/beta/std/iter/trait.IntoIterator.html.
frewsxcv
Metadata
Metadata
Assignees
Labels
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
[-][src] links in beta documentation are broken[/-][+][src] links in beta and nightly documentation are broken[/+]bluss commentedon Nov 10, 2016
Seems to affect some items that libstd reexports from libcore.
alexcrichton commentedon Nov 10, 2016
I'd also be interested in investigating why CI isn't catching this...
GuillaumeGomez commentedon Nov 10, 2016
The
[src]
link should be generated based on the "original" item instead of the current one. (spitting out the obvious)bluss commentedon Nov 11, 2016
Ok, good news, this bug did not migrate to stable when beta did?
alexcrichton commentedon Nov 11, 2016
Something looks off-by-one in the gotosrc links (which is why linkchecker didn't catch this). libstd thinks the iterator trait is 3636 and libcore thinks it's 3637. Sounds like the ids used by rustdoc are perhaps no longer valid?
GuillaumeGomez commentedon Nov 11, 2016
Taking a look.
Rollup merge of rust-lang#37727 - GuillaumeGomez:invalid_src, r=eddyb
bluss commentedon Nov 12, 2016
Thanks for fixing this! rustdoc improvements = ❤️
ollie27 commentedon Nov 18, 2016
This isn't fixed. See
std::str::Chars
. The link is https://doc.rust-lang.org/nightly/core/str/struct.Chars.html?gotosrc=42892 but it should be https://doc.rust-lang.org/nightly/core/str/struct.Chars.html?gotosrc=42906. They differ by 14 which is the same number of items with#[cfg(dox)]
insrc/libcore/macros.rs
so I think it's the same issue.GuillaumeGomez commentedon Nov 18, 2016
Taking another look then.