Skip to content

Tiny doc wording change #39366

@adrian5

Description

@adrian5
Contributor

Sync > Condvar

The predicate is always verified inside of the mutex before determining that thread must block.

Rather "determining that a thread"?

Alloc > Rc

The type Rc<T> provides shared ownership of a value of type T, allocated in the heap.

Rather "allocated on the heap"? That's how it know it.

Activity

phungleson

phungleson commented on Feb 3, 2017

@phungleson
Contributor

Quickly did a search, seems like in the heap is a very common phrase in the doc.

Maybe it is a convention?

adrian5

adrian5 commented on Feb 3, 2017

@adrian5
ContributorAuthor

Yes, I hadn't considered that. It's self-evident that things are (metaphorically) put onto the stack , and maybe programmers adopted that expression for both. For the heap, in works too. Is there a difference in expressing data being written (on), and residing somewhere (in)?

In the book, the section on the stack and heap appears to use on throughout.

added a commit that references this issue on Feb 4, 2017
added 2 commits that reference this issue on Feb 4, 2017
phungleson

phungleson commented on Feb 4, 2017

@phungleson
Contributor

Sorry I accidentally close this via my PR, feel free to reopen this if you want.

My unscientific checking shows that java "on the heap" has the same number of result with java "in the heap" in google so maybe they are both commonly used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @phungleson@adrian5

        Issue actions

          Tiny doc wording change · Issue #39366 · rust-lang/rust