Closed
Description
slice::get_unchecked now takes ranges, whereas str takes explicit usize. str does not provide an explicit method to slice unsafely with ranges either.
Metadata
Metadata
Assignees
Labels
Blocker: Implemented in the nightly compiler and unstable.Category: An issue tracking the progress of sth. like the implementation of an RFCRelevant to the library API team, which will review and decide on the PR/issue.In the final comment period and will be merged soon unless new substantive objections are raised.
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
alexcrichton commentedon Feb 21, 2017
Should be a relatively easy API to add! I believe this just needs to mirror slices and can likely use the same trait for abstractions.
ghost commentedon Feb 21, 2017
i'd like to do it
Auto merge of #40737 - nagisa:safe-slicing-strs, r=BurntSushi
[-]API discrepancy between slice::get{,_unchecked} and str::slice_unchecked[/-][+]Tracking issue for str_checked_slicing[/+]Mark-Simulacrum commentedon Jun 19, 2017
Nominating for libs team discussion -- I think it's reasonable to stabilize this. It's been implemented for about two cycles (PR merged March 31st), I believe. The API surface is fairly small -- extending slice
get{,_unchecked}methods tostrs. It's possible we should deprecate theslice_unchecked{,_mut}methods as we stabilize this extension -- I believe they are obsoleted by this addition.alexcrichton commentedon Jun 20, 2017
@rfcbot fcp merge
Sounds good to me to stabilize!
17 remaining items