Skip to content

rustbuild: test --stage 1 src/test/ui builds "stage1 compiler artifacts" #40016

Closed
@petrochenkov

Description

@petrochenkov
Contributor

while other useful stage 1 tests like compile-fail or run-pass will happily run after building only "stage1 std artifacts".

compile-fail and ui are inseparable and need to be tested together and building "stage1 compiler artifacts" makes the edit-compile-test cycle ~twice longer.

Activity

added
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
on Feb 21, 2017
alexcrichton

alexcrichton commented on Feb 21, 2017

@alexcrichton
Member

To do this we'd have to split the ui test suite between "requires only std" and "requires more than std". I believe there's one test which requires plugins, which needs to build the whole compiler

petrochenkov

petrochenkov commented on Feb 21, 2017

@petrochenkov
ContributorAuthor

Like compile-fail-fulldeps, but ui-fulldeps? (If understand the purpose of fulldeps tests correctly.)

alexcrichton

alexcrichton commented on Feb 21, 2017

@alexcrichton
Member

Indeed!

added a commit that references this issue on Mar 3, 2017

Rollup merge of rust-lang#40236 - petrochenkov:btweak, r=alexcrichton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @alexcrichton@petrochenkov

        Issue actions

          rustbuild: `test --stage 1 src/test/ui` builds "stage1 compiler artifacts" · Issue #40016 · rust-lang/rust