Support rls --version #41197
Description
Right now the rls executable we're going to start shipping doesn't support rls --version, but we've got a relatively standard format between rls/cargo that should be supported. Cargo's looks like this and we probably want the RLS logic to look similar.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
Participants
Activity
alexcrichton commentedon Apr 10, 2017
cc #40584, @nrc, @jonathandturner
(you may wish to open a tracking issue in the rls repo to track this)
sophiajt commentedon May 14, 2017
The RLS currently has a --version flag. Is this bug tracking it landing in rustup?
sophiajt commentedon May 14, 2017
(lol, just noticed the date of the bug...)
alexcrichton commentedon May 15, 2017
Aha yep! Just ran this:
Looks great to me! The only missing piece I believe is the "-nightly" or "-beta" piece. @jonathandturner do you know the right person to cc about that?
sophiajt commentedon May 15, 2017
I'd CC @nrc since he's overseeing RLS and can handle it
nrc commentedon May 16, 2017
I added
-nightlyto the version string. The RLS is always nightly for now since we are not going though beta, etc. at the moment. Is that going to work for Rustbuild?AIUI Rustbuild should actually use the flag, rather than do whatever placeholder thing it does at the moment.
alexcrichton commentedon May 16, 2017
Ok thanks @nrc! It sounds like we're going to discuss more of the stability story for the rls soon anyway? May be best to defer some of this to then if so.