Skip to content

Tracking issue: improve error messages for IDEs #42823

Closed
@nrc

Description

@nrc
Member

This is just a grab bag of things that would improve errors in IDEs via the RLS. These all apply to JSON errors rather than human-readable ones, where that's relevant

  • replace help with suggestions where possible
    add suggestions that are not user-visible in human-readable output (e.g., to delete unused functions)
    add suggestions in general (in particular, imports for name resolution errors)
    implement the rendered field for all error types (currently only used by suggestions)
    make sure the main error message reads well by itself without any span labels
    if possible, suggestion labels should describe the action rather than the problem

cc @oli-obk @killercup @jonathandturner @est31

Activity

added
A-diagnosticsArea: Messages for errors, warnings, and lints
T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.
on Jun 22, 2017
oli-obk

oli-obk commented on Jun 22, 2017

@oli-obk
Contributor

I already added import suggestions in #41876 and am improving more name resolution errors in #42033, but there's an inherent issue with the current name resolution impl and reporting path suggestions ( see PR for details)

nrc

nrc commented on Jun 22, 2017

@nrc
MemberAuthor

I'm assuming the inherent issue is #42033 (comment)

My impression is that there are suggestions for some name resolution errors, but not all of them? And thus that there is still work to do here (I would like to nail this down more precisely).

cc @jseyfried too

oli-obk

oli-obk commented on Jun 22, 2017

@oli-obk
Contributor

Yes that is the issue description. The entire error reporting in resolve needs to be revamped I think.

I was trying to add them incrementally, as to not produce an immense unmanageable PR. These kind of changes produce a lot of churn in ui tests

added
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
on Jul 26, 2017
oli-obk

oli-obk commented on Jan 16, 2018

@oli-obk
Contributor

The 4th box has been implemented in #46052

estebank

estebank commented on Apr 8, 2019

@estebank
Contributor

I believe all the actionable items in this ticket have already been addressed and the last two are ongoing concerns that belong in documentation, not an open ticket. Does anyone have an objection to closing this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lintsC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @oli-obk@nrc@estebank@Mark-Simulacrum

        Issue actions

          Tracking issue: improve error messages for IDEs · Issue #42823 · rust-lang/rust