Closed
Description
This is just a grab bag of things that would improve errors in IDEs via the RLS. These all apply to JSON errors rather than human-readable ones, where that's relevant
- replace help with suggestions where possibleadd suggestions that are not user-visible in human-readable output (e.g., to delete unused functions)add suggestions in general (in particular, imports for name resolution errors)implement the
rendered
field for all error types (currently only used by suggestions)make sure the main error message reads well by itself without any span labelsif possible, suggestion labels should describe the action rather than the problem
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
oli-obk commentedon Jun 22, 2017
I already added import suggestions in #41876 and am improving more name resolution errors in #42033, but there's an inherent issue with the current name resolution impl and reporting path suggestions ( see PR for details)
nrc commentedon Jun 22, 2017
I'm assuming the inherent issue is #42033 (comment)
My impression is that there are suggestions for some name resolution errors, but not all of them? And thus that there is still work to do here (I would like to nail this down more precisely).
cc @jseyfried too
oli-obk commentedon Jun 22, 2017
Yes that is the issue description. The entire error reporting in resolve needs to be revamped I think.
I was trying to add them incrementally, as to not produce an immense unmanageable PR. These kind of changes produce a lot of churn in ui tests
;
on methods with return type()
#42850oli-obk commentedon Jan 16, 2018
The 4th box has been implemented in #46052
estebank commentedon Apr 8, 2019
I believe all the actionable items in this ticket have already been addressed and the last two are ongoing concerns that belong in documentation, not an open ticket. Does anyone have an objection to closing this ticket?