Skip to content

Privatize appropriate struct fields in core and std #4386

Closed
@bstrie

Description

@bstrie
Contributor
< bstrie> pcwalton: do you know why priv is commented out on this line in
          std::future? 
          https://github.com/mozilla/rust/blob/master/src/libstd/future.rs#L30
<@brson> bstrie: because the priv keyword wasn't supported there at the
         time. it's a reminder that that field should be 'priv'
< bstrie> ok, so that should be changed then
<@brson> yes

Find all priv fields of this type and uncomment them. Should perhaps also go through the rest of the libraries and stick priv qualifiers wherever their use may have been overlooked.

Activity

wting

wting commented on Jan 11, 2013

@wting
Contributor

Trying to add priv to this line causes the error: error: unmatched visibility. I'm not sure what that means though...

Also, how would we know where it's appropriate to add priv qualifiers?

Edit: Never mind about the 1st point:

< strcat> wting: I don't think you can make the extern mod stuff not get re-exported atm

catamorphism

catamorphism commented on Jul 1, 2013

@catamorphism
Contributor

(bug triage) Still an issue; good easy starter project.

pnkfelix

pnkfelix commented on Sep 24, 2013

@pnkfelix
Member

triage, email from 2013-09-09. Nothing to add.

brson

brson commented on Oct 30, 2013

@brson
Contributor

This is done I think thanks to @reedlepee123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @brson@pnkfelix@catamorphism@wting@bstrie

        Issue actions

          Privatize appropriate struct fields in core and std · Issue #4386 · rust-lang/rust