Skip to content

Remove stage0 allocator logic from MSVC in libstd #44217

Closed
@alexcrichton

Description

@alexcrichton
Member

We're updating the bootstrap compiler in #44154 which attempted to remove the MSVC-specific logic here (added in #43589) but I believe that caused this failure.

No time to debug just yet, but we should remove this one day!

Activity

alexcrichton

alexcrichton commented on Aug 31, 2017

@alexcrichton
MemberAuthor
aidanhs

aidanhs commented on Aug 31, 2017

@aidanhs
Member

Well beta-2017-08-29 does seem to have the code in it, so...hmm -

if tcx.sess.allocator_kind.get().is_some() {
for method in ALLOCATOR_METHODS {
local_crate.push((format!("__rust_{}", method.name),
INVALID_DEF_ID,
SymbolExportLevel::Rust));
}
}

alexcrichton

alexcrichton commented on Aug 31, 2017

@alexcrichton
MemberAuthor

Oh I should also clarify that I'm not even sure this is the actual bug. I'm likely to close this after further investigation of updating the bootstrap compiler...

alexcrichton

alexcrichton commented on Sep 1, 2017

@alexcrichton
MemberAuthor

Ok opening a new bug

alexcrichton

alexcrichton commented on Sep 1, 2017

@alexcrichton
MemberAuthor

I opened up #44236, I think this may mean that __rust prefixes are the wrong ones and we're supposed to use the __rg ones, but there's no real motivation to fix this immediately so I'm not going to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    O-windows-msvcToolchain: MSVC, Operating system: Windows

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @alexcrichton@aidanhs

        Issue actions

          Remove stage0 allocator logic from MSVC in libstd · Issue #44217 · rust-lang/rust