Skip to content

simplify variance #45471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikomatsakis opened this issue Oct 23, 2017 · 4 comments
Closed

simplify variance #45471

nikomatsakis opened this issue Oct 23, 2017 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-incr-comp Working group: Incremental compilation

Comments

@nikomatsakis
Copy link
Contributor

Before red-green, the incremental tracking for variance computation had to do some complex stuff, as described here. This can be removed now. This means ripping out the dependencies field and the various bits of code that were needed to keep it updated. We should also be able to remove this block of code that injects "extra" dependencies and -- crucially -- the with_ignore call on this line.
@nikomatsakis nikomatsakis added E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-incr-comp Working group: Incremental compilation labels Oct 23, 2017
@SimonSapin
Copy link
Contributor

I’ll work on this.

@SimonSapin SimonSapin mentioned this issue Oct 23, 2017
Merged
SimonSapin added a commit to SimonSapin/rust that referenced this issue Oct 23, 2017
@SimonSapin
Remove dependency tracking for variance computation
94edd8f 
This custom tracking is now replaced by the red/green algorithm.

Fix rust-lang#45471
@power10dan
Copy link

Hi, I don't know if this is the right place, but I would also like to give this issue a try.
Is there any way that I can get started?

@SimonSapin
Copy link
Contributor

Hi @power10dan. Instructions are in the original message, but this issue already has a PR: #45473

@power10dan
Copy link

Oh got it! Thanks for letting me know!

@TimNN TimNN added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Oct 24, 2017
bors added a commit that referenced this issue Oct 25, 2017
@bors
Auto merge of #45473 - SimonSapin:variance-red-green, r=nikomatsakis
b247805 
Remove dependency tracking for variance computation

This custom tracking is now replaced by the red/green algorithm.

Fix #45471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-incr-comp Working group: Incremental compilation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nikomatsakis @SimonSapin @TimNN @power10dan