Skip to content

Remove structural records from libcore, libstd, macros #4665

Closed
@catamorphism

Description

@catamorphism
Contributor

libcore has structural records removed for the most part (thanks to @erickt 's heroic work!) but a few modules still have it enabled because the pipes code generates code with structural records. I'm a little afraid to fix the pipes compiler (I'm not sure how to make it generate new names for struct types), but could with some help.

The extfmt code also needs to be changed to not generate structural records.

Finally (for now), libstd needs to have records removed as well.

Activity

erickt

erickt commented on Jan 29, 2013

@erickt
Contributor

I already landed my extfmt and pipes patches, and most of libstd has been converted too. I'm just waiting on a snapshot to remove my #[cfg(stage...)] blocks.

catamorphism

catamorphism commented on Jan 29, 2013

@catamorphism
ContributorAuthor

@erickt Great, thanks! Sorry, I must have read your patches hastily and didn't notice that you also fixed extfmt and pipes :-)

catamorphism

catamorphism commented on Jan 29, 2013

@catamorphism
ContributorAuthor

I have a new snapshot ready that should work for this; currently running try.

catamorphism

catamorphism commented on Feb 4, 2013

@catamorphism
ContributorAuthor

I've de-recorded libstd and am just running tests. I also have a snapshot branch that should build, but is not compiling on the Mac and Linux bots (I'm investigating).

added a commit that references this issue on Feb 5, 2013
added a commit that references this issue on Feb 5, 2013

auto merge of #4796 : catamorphism/rust/derecord_std, r=catamorphism

catamorphism

catamorphism commented on Feb 7, 2013

@catamorphism
ContributorAuthor

I forgot to remove one use of structural records from the pipes compiler ( gen_buffer_init in libsyntax/ext/pipec.rs). >:-(

catamorphism

catamorphism commented on Feb 19, 2013

@catamorphism
ContributorAuthor

I'll try to finish this now that df4273f is in. Specifically I'll start a snapshot building.

catamorphism

catamorphism commented on Feb 19, 2013

@catamorphism
ContributorAuthor

Snapshot is now building.

bstrie

bstrie commented on Mar 7, 2013

@bstrie
Contributor

I think this can be closed now.

3 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-syntaxextArea: Syntax extensionsC-cleanupCategory: PRs that clean code up or issues documenting cleanup.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @erickt@nikomatsakis@catamorphism@bstrie

        Issue actions

          Remove structural records from libcore, libstd, macros · Issue #4665 · rust-lang/rust