-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-codegenArea: Code generationArea: Code generationO-ArmTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 stateTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state
Description
In #35814, the armv7-unknown-linux-gnueabihf
target was changed to not use NEON, but the armv7-unknown-linux-musleabihf
target was not changed. I just used the musl target to compile a binary for my router (OpenWRT uses musl), but it dies with "Illegal instruction" in Mutex::new
on vld1.32
(a NEON instruction).
$ rustc --print cfg --target armv7-unknown-linux-musleabihf | grep neon
target_feature="neon"
Should armv7-unknown-linux-musleabihf
have NEON disabled as well? I think it is confusing to have one armv7 target with NEON enabled and the other with it disabled.
Metadata
Metadata
Assignees
Labels
A-codegenArea: Code generationArea: Code generationO-ArmTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 stateTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
alexcrichton commentedon Jan 26, 2018
Ah yeah seems like an oversight on our part! I think it'd be fine to remove neon for consistency with the gnu target
Rollup merge of rust-lang#48466 - sanxiyn:no-neon, r=alexcrichton
Rollup merge of rust-lang#48466 - sanxiyn:no-neon, r=alexcrichton
armv7-unknown-linux-musleabihf
/armv7-linux-musleabihf
hard-coded NEON support cross-rs/cross#252thumbv7neon_linux_androideabi
andthumbv7neon-unknown-linux-gnueabihf
targets cross-rs/cross#254