Skip to content

Possibly merge resolve_definition_of_name_in_module with resolve_name_in_module #4952

New issue
New issue
Closed
Closed
Possibly merge resolve_definition_of_name_in_module with resolve_name_in_module#4952
Labels
A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
@catamorphism

Description

@catamorphism
catamorphism
opened on Feb 15, 2013
Contributor

As per comment in the former function in resolve.

Activity

emberian

emberian commented on Jul 7, 2013

@emberian
emberian
on Jul 7, 2013
Member

Still relevant

thestinger

thestinger commented on Aug 19, 2013

@thestinger
thestinger
on Aug 19, 2013
Contributor

Triage bump.

huonw

huonw commented on Jan 31, 2014

@huonw
huonw
on Jan 31, 2014
Member

Still there.

ahmedcharles

ahmedcharles commented on May 28, 2014

@ahmedcharles
ahmedcharles
on May 28, 2014
Contributor

I looked into this, it seems less trivial than I imagined, because the functions don't seem to do the same thing or return the same types (or at least, I don't know enough to recognize the similarities).

tamird

tamird commented on Apr 26, 2015

@tamird
tamird
on Apr 26, 2015
Contributor

There's a whole host of duplication in librustc_resolve/lib.rs, but refactoring it would require lots of closure-passing. I'm not really sure it's appropriate to mark as E-easy :(

jseyfried
mentioned this on Nov 3, 2015
nrc

nrc commented on Nov 24, 2015

@nrc
nrc
on Nov 24, 2015
Member

Fixed by #29530

nrc
closed this as completedon Nov 24, 2015
flip1995
added a commit that references this issue on Apr 21, 2022

Auto merge of rust-lang#8667 - Jarcho:proc_macro_check, r=flip1995

89ee6aa
arcnmx
added a commit that references this issue on Dec 17, 2022

Auto merge of rust-lang#13742 - lowr:fix/assoc-type-shorthand-with-ga…

518e39b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @catamorphism@emberian@nrc@huonw@thestinger

        Issue actions
          Possibly merge resolve_definition_of_name_in_module with resolve_name_in_module · Issue #4952 · rust-lang/rust