Closed
Description
One thing i noticed about this lint is that it's firing for items that aren't even being exported. For example, in this build log, there are a lot of repeat hits for the cfg_if!
macro, even though i would not expect all of these crates to be re-exporting the macro. In one particular situation, it seems to have caused a crate with #![deny(warnings)]
on it to fail to build, just because of this dependency! We should probably wait to emit these lints until the passes which strip items have been run, to reduce some of these erroneous reports.
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
QuietMisdreavus commentedon Jun 21, 2018
cc @GuillaumeGomez since you implemented both the lint and the warning that preceded it.
QuietMisdreavus commentedon Jun 21, 2018
cc #43466 as well since it's an intra-doc-link problem
cargo doc
fails for the h2 crate (v0.1.9) on nightly 2018-06-05 #51468clarfonthey commentedon Jul 8, 2018
Just ran into this. I would like to see these capped to warn like they are normally for lints on dependency crates, rather than preventing a doc build on my crate for something I can't control.
GuillaumeGomez commentedon Jul 8, 2018
You can now play with cap-lints with rustdoc just like you would with rustc. However, this issue is a separate problem which needs to be fixed on its own.
nrc commentedon Jul 18, 2018
It would be good, I think, to automatically suppress this lint for all dependent crates by default.
Perhaps off-topic, but this lint seems to be firing a lot for some crates (crossbeam, regex, and (I think) std). Many of these look like markdown links, which presumably we should not be firing the lint for?
QuietMisdreavus commentedon Jul 28, 2018
It took a bit of a refactor, but i've posted #52800 to solve this issue.