Skip to content

Custom derive: can't use const as attribute value #52393

Open
@srijs

Description

@srijs
Contributor

I'm using serde to implement deserialization for a custom protocol. To keep the code dry, I've pulled all relevant strings into constants, but that creates a problem when trying to use the constants as attributes values in serde's derive macro.

Here's a playground with a minimal example to reproduce the problem: http://play.rust-lang.org/?gist=47230ae9671b24b312bef9540e520ddf&version=stable&mode=debug&edition=2015

The check that seems to produce the error is part of libsyntax:

let found = self.this_token_to_string();
let msg = format!("expected unsuffixed literal or identifier, found {}", found);
Err(self.diagnostic().struct_span_err(lo, &msg))

With my very basic knowledge of the rust compiler, I can see two potential ways this could be made possible:

  1. Run derive macros after the constants have been expanded. This would be transparent to the macros (they could treat the expanded constants as literals), however this might be a no-go due to the way that the passes are ordered within rustc?

  2. Relax the check in libsyntax (and possibly other places) to allow for identifiers to be valid attribute values on the syntax level, so that custom derive macros could use the identifier as part of their code gen (this wouldn't work for all macros, but at least for serde it looks like it'd be good enough).

If possible, could you give an indication as to whether this is something that you'd like in the compiler (in which case I'd be interested in working on a PR or RFC for it), or whether you think this is either impossible or undesirable for any reason?

Activity

changed the title [-]can't use const as attribute value[/-] [+]Custom derive: can't use const as attribute value[/+] on Jul 15, 2018
added
A-attributesArea: Attributes (`#[…]`, `#![…]`)
A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
on Mar 23, 2019
added
C-bugCategory: This is a bug.
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Nov 10, 2019
webern

webern commented on Aug 12, 2021

@webern

I'm surprised this issue doesn't have more upvotes. Is this issue represented somewhere else where it has more of a following? What I want to do is this:

const SOME_CONST: &str = "foobar";

#[some_derive_macro(name = SOME_CONST)]
struct Whatever {

}
thomcc

thomcc commented on Aug 12, 2021

@thomcc
Member

Yeah, you can't put consts in attributes, but it would be very nice. I'm not sure if solving this requires an RFC, but it might.

EDIT: For proc macros, the macro could probably solve it in many cases, but would have to be changed.

oldgalileo

oldgalileo commented on Jun 30, 2022

@oldgalileo

The include_str! macro seems related, but I'm curious if there's been any work unlinked here that enables the usage of a const _: &str in an attribute yet?

glyh

glyh commented on Apr 11, 2024

@glyh

Potential use case: pomsky + logos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-attributesArea: Attributes (`#[…]`, `#![…]`)A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)A-proc-macrosArea: Procedural macrosC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @thomcc@Aaron1011@jonas-schievink@oldgalileo@srijs

        Issue actions

          Custom derive: can't use const as attribute value · Issue #52393 · rust-lang/rust