Skip to content

[1.30 beta] tester crate broken #54466

Closed
Closed
@pietroalbini

Description

@pietroalbini
Member

This regression will probably be marked as "won't fix". This issue notifies crate authors.

The tester crate doesn't work anymore on 1.30 beta. The rationale for this is in #53410 (comment).

Activity

added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Sep 22, 2018
added this to the 1.30 milestone on Sep 22, 2018
pnkfelix

pnkfelix commented on Sep 27, 2018

@pnkfelix
Member

Closing as WONTFIX based on previously linked reasoning #53410 (comment), transcribed below for posterity:

Also @alexcrichton it looks like I broke this: https://crates.io/crates/tester but I don't think that should have ever been allowable in the first place.

It used an implementation detail of how the compiler used libtest to test itself, to trick the stable compiler into thinking that tester was actually libtest and allow it to test itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @pnkfelix@pietroalbini

        Issue actions

          [1.30 beta] tester crate broken · Issue #54466 · rust-lang/rust