Skip to content

compiletest: //~ ERROR annotations are ignored in compile-pass tests #56277

Closed
@petrochenkov

Description

@petrochenkov
Contributor

Reproduction:

// compile-pass

fn main() {} //~ ERROR any misleading message

The test passes despite the incorrect //~ ERROR annotation.

Tests often have these annotations while they are WIP, but then everything is good, the test passes and is marked as // compile-pass, but stray //~ ERROR annotations may remain confusing the reader.

Activity

added
A-testsuiteArea: The testsuite used to check the correctness of rustc
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
E-help-wantedCall for participation: Help is requested to fix this issue.
on Nov 27, 2018
petrochenkov

petrochenkov commented on Nov 27, 2018

@petrochenkov
ContributorAuthor

Somewhat similar to #55596

added a commit that references this issue on Oct 29, 2019

Rollup merge of rust-lang#65759 - tmiasko:ui, r=petrochenkov

d4efde0
added 2 commits that reference this issue on Nov 1, 2019

Rollup merge of rust-lang#65759 - tmiasko:ui, r=petrochenkov

a5efbe3

Rollup merge of rust-lang#65759 - tmiasko:ui, r=petrochenkov

098478e
added 3 commits that reference this issue on Nov 2, 2019

Auto merge of #65759 - tmiasko:ui, r=petrochenkov

8e6ddca

Auto merge of #65759 - tmiasko:ui, r=petrochenkov

b43a682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcE-help-wantedCall for participation: Help is requested to fix this issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @petrochenkov

      Issue actions

        compiletest: `//~ ERROR` annotations are ignored in `compile-pass` tests · Issue #56277 · rust-lang/rust