-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Closed
Labels
T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Description
A set of intrinsics are no longer present it seems (perhaps in LLVM?); see log in https://crater-reports.s3.amazonaws.com/beta-1.33-1/beta-2019-01-22/reg/basic_dsp-0.6.0/log.txt.
cc @rust-lang/libs @liebharc
Metadata
Metadata
Assignees
Labels
T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
hanna-kruppe commentedon Jan 28, 2019
This is an unstable feature removed in #57416. It appears the☹️
simd
crate (which basic_dsp uses) sets RUSTC_BOOTSTRAP to use unstable features on stable/betaliebharc commentedon Jan 28, 2019
For
basic_dsp
users:simd
is an optional dependency ofbasic_dsp
. So as a workaround people should still be able to compile it with--no-default-features --std
.At the time
basic_dsp
was created thesimd
crate was the only explicit SIMD support in Rust. I haven't followed SIMD development in Rust that closely in the last year, but it seems that there are alternatives tosimd
. So that would be a possibility for me to address this.Please let me know how you would like to proceed with this issue.
alexcrichton commentedon Jan 28, 2019
Looks like @rkruppe is right and I believe the bug here is not in @liebharc's
basic_dsp
crater but rather the dependency onsimd
. SettingRUSTC_BOOTSTRAP
is definitely not covered by our stability policy, which I believe is already known, so I'm going to close this.alexcrichton commentedon Jan 28, 2019
@liebharc in the meantime if you'd like to remove the dependency on
simd
the recommendations are:std::arch
if functionality is already implemented therestd::arch
via thestdsimd
repositoryinline assemblycompiled assembly via thecc
cratesimd
but understanding that it's nightly only for now