SIGILL in byond

[Mark-Simulacrum]

I suspect this is actually just UB -- https://github.com/PJB3005/byond-rs/blob/master/src/call.rs#L77-L79 looks like it's storing pointers to freed memory -- but I could be misinterpreting, so filing an issue for further investigation.

https://crater-reports.s3.amazonaws.com/beta-1.33-1/beta-2019-01-22/reg/byond-0.3.2/log.txt

cc @PJB3005

[PJB3005]

I've been cc'd on here before for UB. Isn't the issue that I'm testing panics across extern C boundaries or did something else break this time? I've been too lazy to fix the tests.

I don't see how the code linked has use after free, the cstrs are stored in a vec so they're freed only after the callback is finished. I could be wrong though.

[Mark-Simulacrum]

Ah, yes, I missed the cstr vec. If there's a panic across an ABI boundary then that would be the cause here most likely. Since that change in behavior is expected, I'm closing this.