You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, this is trickier than I thought. The _DERIVE_ constants are an implementation detail of synstructure, which are used to ensure hygiene for the generated impls. They appear because we pass --document-private-items while generating the compiler docs.
I thought that I would be able to add #[doc(hidden)] to synstructure, but unfortunately the --document-private-items flag also removes the strip-hidden pass.
I suppose we have two options:
Modify synstructure to add #[doc(hidden)] to the generated constants, and modify rustbuild to keep the strip-hidden pass when generating compiler docs.
Wait until synstructure can achieve the same hygiene effect through a feature like underscore constants.
Activity
euclio commentedon Apr 22, 2019
I'm working on this.
euclio commentedon Apr 23, 2019
So, this is trickier than I thought. The
_DERIVE_
constants are an implementation detail of synstructure, which are used to ensure hygiene for the generated impls. They appear because we pass--document-private-items
while generating the compiler docs.I thought that I would be able to add
#[doc(hidden)]
to synstructure, but unfortunately the--document-private-items
flag also removes thestrip-hidden
pass.I suppose we have two options:
#[doc(hidden)]
to the generated constants, and modify rustbuild to keep thestrip-hidden
pass when generating compiler docs.Rollup merge of rust-lang#60885 - euclio:strip-synstructure-consts, r…
Rollup merge of rust-lang#60885 - euclio:strip-synstructure-consts, r…
Rollup merge of rust-lang#60885 - euclio:strip-synstructure-consts, r…