Skip to content

Were all the run-make tests meant to to be moved to run-make-fulldeps? #66085

Closed
@pnkfelix

Description

@pnkfelix
Member

#48883 moved the run-make tests to run-make-fulldeps

But a lot of the run-make tests can be run against the stage1 compiler.

From the description on PR #48883, I am not clear on whether the run-make move to run-make-fulldeps was meant to be permanent, or just a temporary way to test a change that accidentally got committed.

Activity

added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
A-testsuiteArea: The testsuite used to check the correctness of rustc
on Nov 4, 2019
Centril

Centril commented on Nov 5, 2019

@Centril
Contributor
alexcrichton

alexcrichton commented on Nov 5, 2019

@alexcrichton
Member

I didn't want that PR to bounce and I didn't want to start testing more than we were already testing, so yes it was intentional that everything moved. It's true that some items could be moved back, I just didn't want to do the work to do that personally.

pnkfelix

pnkfelix commented on Nov 6, 2019

@pnkfelix
MemberAuthor

That's fine; I just wanted to make sure there wasn't some reason I wasn't seeing for trying to move tests back to run-make if possible.

ehuss

ehuss commented on Jun 3, 2022

@ehuss
Contributor

Also beware that run-make-fulldeps is now treated differently in CI for various reasons. For example, the macOS tests are split into separate runners because they take too long to run and run-make-fulldeps is one of the suites that is split up. Also, the "debug" runner only runs the run-make-fulldeps tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @ehuss@alexcrichton@pnkfelix@Centril

      Issue actions

        Were all the run-make tests meant to to be moved to run-make-fulldeps? · Issue #66085 · rust-lang/rust