Skip to content

x.py --json-output suppresses CompilerArtifact messages #73209

Closed
@RalfJung

Description

@RalfJung
Member

When using x.py --json-output, I would expect JSON output to be basically the same as standard cargo. However, that does not seem to be the case: an analysis of rust-lang/rust-analyzer#4827 by @bjorn3 revealed that CompilerArtifact are not propagated properly.

Cc @Mark-Simulacrum

Activity

added
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
C-bugCategory: This is a bug.
on Jun 10, 2020
Mark-Simulacrum

Mark-Simulacrum commented on Jun 10, 2020

@Mark-Simulacrum
Member

Problem is here: https://github.com/rust-lang/rust/blob/master/src/bootstrap/compile.rs#L985-L989

Those lines should probably be modified such that we unconditionally print the received line if the --json-output flag is passed?

bjorn3

bjorn3 commented on Jun 10, 2020

@bjorn3
Member

Yes

added a commit that references this issue on Jun 11, 2020

Rollup merge of rust-lang#73219 - RalfJung:cargo-json, r=Mark-Simulacrum

ef5de43
added a commit that references this issue on Jun 11, 2020

Rollup merge of rust-lang#73219 - RalfJung:cargo-json, r=Mark-Simulacrum

ba0a8d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @RalfJung@jonas-schievink@Mark-Simulacrum@bjorn3

      Issue actions

        `x.py --json-output` suppresses `CompilerArtifact` messages · Issue #73209 · rust-lang/rust