Skip to content

[rustdoc] ALIASES[crate] is undefined #73620

Closed
@tesuji

Description

@tesuji
Contributor

I loaded the std doc at https://doc.rust-lang.org/nightly/std/index.html in Firefox 77.0.1,
then I typed fast for the word "true" (or click this link: https://doc.rust-lang.org/nightly/std/index.html?search=true).

I expected to see this happen: The search result appears and includes the "true" keyword link.

Instead, this happened: No search result was shown.
Also in the Firefox console, this was printed after typing the word "true":

TypeError: ALIASES[crate] is undefined 3 main1.46.0.js:formatted:869
    handleAliases main1.46.0.js:869
    execQuery main1.46.0.js:1110
    execSearch main1.46.0.js:1407
    search main1.46.0.js:1457

Meta

Version of std docs: 1.46.0-nightly (a8cf399 2020-06-21)

cc @jyn514 in case you interest.

Activity

tesuji

tesuji commented on Jun 22, 2020

@tesuji
ContributorAuthor

The type error happened along this line:

for (i = 0; i < ALIASES[crate][query.search].length; ++i) {

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Jun 22, 2020
ollie27

ollie27 commented on Jun 23, 2020

@ollie27
Member

It looks like it fails when you have a crate filter selected. Almost certainly caused by #71724 (cc @GuillaumeGomez).

added
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Jun 23, 2020
tesuji

tesuji commented on Jun 23, 2020

@tesuji
ContributorAuthor

It looks like it fails when you have a crate filter selected

yeah, that's right. I forgot about that detail.

ollie27

ollie27 commented on Jun 23, 2020

@ollie27
Member

#73644 should fix this.

added a commit that references this issue on Jun 23, 2020

Auto merge of rust-lang#73644 - ollie27:rustdoc_alias_filter, r=Guill…

ff5b446
removed
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @jonas-schievink@ollie27@tesuji@jyn514@rustbot

      Issue actions

        [rustdoc] ALIASES[crate] is undefined · Issue #73620 · rust-lang/rust