Skip to content

Rename "important traits" to something better #75245

Closed
@Manishearth

Description

@Manishearth
Member

A lot of the feedback on https://internals.rust-lang.org/t/feedback-on-important-traits-rustdoc-feature/12752 had better suggestions for the "important traits" feature.

Some options were:

  • Featured traits
  • Key traits
  • Notable traits

My personal preference is for "notable traits" because "important" is a much stronger value judgement whereas "notable" basically means "we thought you should know this" which is exactly what the feature does.

Thoughts? @rust-lang/rustdoc

We should pick something and rename.

Activity

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Aug 7, 2020
GuillaumeGomez

GuillaumeGomez commented on Aug 7, 2020

@GuillaumeGomez
Member

I don't have strong feelings here but I think "Notable traits" is the best proposition out of the three.

jyn514

jyn514 commented on Aug 7, 2020

@jyn514
Member

I agree 👍 , "featured traits" might be confused with cargo features and "key traits" has different connotations in my mind.

added
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
on Aug 7, 2020
added
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
on Aug 7, 2020
camelid

camelid commented on Aug 9, 2020

@camelid
Member

I'd be interested in doing this.

@rustbot claim

added a commit that references this issue on Aug 10, 2020

Rollup merge of rust-lang#75344 - camelid:rename-important-to-notable…

8176240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @Manishearth@GuillaumeGomez@jyn514@camelid

    Issue actions

      Rename "important traits" to something better · Issue #75245 · rust-lang/rust