Skip to content

miri no longer builds after rust-lang/rust#79167 #79176

Closed
@rust-highfive

Description

@rust-highfive
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #79167, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @m-ou-se, do you think you would have time to do the follow-up work?
If so, that would be great!

Activity

m-ou-se

m-ou-se commented on Nov 18, 2020

@m-ou-se
Member

That PR was a rollup. Without having looked at any logs, I'm guessing this is caused by Edit: Oh uh, nope, sorry, had a different change in mind. Will take a closer look. :)

m-ou-se

m-ou-se commented on Nov 18, 2020

@m-ou-se
Member

Ah, the problem is #78785

error: unsupported operation: unsupported Linux dlsym: getrandom
   --> /home/mara/dev-ext/rust/library/std/src/sys/unix/weak.rs:100:5
    |
100 |     libc::dlsym(libc::RTLD_DEFAULT, name.as_ptr()) as usize
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unsupported Linux dlsym: getrandom

The call to getrandom() was changed from syscall(SYS_getrandom, ..) to try dlsym("getrandom") first. Returning null there would work fine, as it still falls back to syscall(SYS_getrandom, ..).

Edit: And the same for statx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

A-miriArea: The miri toolC-bugCategory: This is a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @eddyb@RalfJung@oli-obk@m-ou-se@rust-highfive

    Issue actions

      `miri` no longer builds after rust-lang/rust#79167 · Issue #79176 · rust-lang/rust