-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
Right now, there are two different download settings: download-ci-llvm
and download-rustc
. They are pretty similar and I imagine the knobs we'll want to tweak will be the same for both (e.g. it seems reasonable to add "if-unchanged"
to download-ci-llvm
now that download-rustc has it: #83368). Additionally, this could be extended without too much trouble to other tools and components, like rustdoc, clippy, etc. It would be nice to combine these together in to one option (maybe download-component
). I'd expect the old options to work but give a warning to use the new syntax.
Another feature could be to support multiple requirements, or individual components:
download-component = "clippy,llvm"
download-component = "rustc=if-unchanged,llvm=if-available"
download-component = "if-unchanged,if-available"
Metadata
Metadata
Assignees
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
download-rustc
#81930Mark-Simulacrum commentedon Mar 22, 2021
I think unifying the backend implementation is OK. I don't care much about avoiding multiple options in the frontend; I think it's not necessarily bad but also seems like there's not much purpose to it - I guess I'm wondering why multiple options would be all that bad.
camelid commentedon Mar 24, 2021
Semi-related: There's some inconsistency in naming because there's
download-ci-llvm
but alsodownload-rustc
. Not a big deal, but it seems like-ci-
should be added to the latter or removed from the former.jyn514 commentedon May 7, 2021
I don't think this is a very useful change.