-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.P-highHigh priorityHigh priorityT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.Performance or correctness regression from one stable version to another.
Description
I tried this code:
use std::path::{Path, PathBuf};
pub struct Foo(PathBuf);
impl std::ops::Deref for Foo {
type Target = Path;
fn deref(&self) -> &Path { &self.0 }
}
I expected to see this happen: Rustdoc shows the docs for Path::from_str
on the docs for Foo
, like it used to in 1.51:
Instead, this happened: Rustdoc does not generate those methods:
Meta
searched nightlies: from nightly-2021-04-01 to nightly-2021-07-30
regressed nightly: nightly-2021-06-16
searched commits: from 539d7bd to 607d6b0
regressed commit: d74b36e
bisected with cargo-bisect-rustc v0.6.0
Host triple: x86_64-unknown-linux-gnu
Reproduce with:
cargo bisect-rustc --script ./docs-exist.sh --start 2021-04-01
where docs-exist.sh
is
#!/bin/sh
cargo doc
grep 'Methods from Deref' ${CARGO_TARGET_DIR:-target}/doc/hello_world/foo/struct.Foo.html
cc @pnkfelix
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.P-highHigh priorityHigh priorityT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.Performance or correctness regression from one stable version to another.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
apiraino commentedon Aug 5, 2021
Assigning priority as discussed in the Zulip thread of the Prioritization Working Group.
@rustbot label -I-prioritize +P-high
Rollup merge of rust-lang#90183 - GuillaumeGomez:recurse-deref, r=jyn514