Skip to content

Incorrect error note for empty implementations #9580

Closed
@SiegeLord

Description

@SiegeLord
Contributor
impl A for B;

gives this error:

test.rs:1:12: 1:13 error: obsolete syntax: empty implementation
test.rs:1 impl A for B;
                      ^
note: instead of `impl A;`, write `impl A {}`
error: aborting due to previous error

The note is talking about a different construct. It could use a more generic language to refer to trait implementations and non-trait implementations. I also question handling this via the obsolete syntax pathway, as it seems to leak historical details that are not too relevant for a Rust user.

Activity

added a commit that references this issue on Jan 31, 2014
edb9f82
huonw

huonw commented on Feb 1, 2014

@huonw
Member

triage: I've just removed the special handling in #11966, so it's now a normal syntax error to write impl A for B;. (Will be closed when that lands.)

added a commit that references this issue on Oct 6, 2022

Auto merge of rust-lang#9580 - TennyZhuang:upper_case_acronyms-enum, …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lints

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @SiegeLord@huonw

        Issue actions

          Incorrect error note for empty implementations · Issue #9580 · rust-lang/rust