Skip to content

[regression] ambiguity libc/ffi/os::raw for c_ types #96435

Closed

Activity

added
T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.
T-libsRelevant to the library team, which will review and decide on the PR/issue.
on Apr 26, 2022
added this to the 1.61.0 milestone on Apr 26, 2022
added
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Apr 26, 2022
petrochenkov

petrochenkov commented on Apr 26, 2022

@petrochenkov
Contributor

One reasonable fix is to stabilize these types in std::ffi.
That will allow using use reexports instead of type aliases, which will remove the ambiguities.
They are the same types as stable types in std::os::raw just exposed from a different (but also stable) location in the same crate.

(That said, glob vs glob is an acceptable breakage according to the library policy.)

joshtriplett

joshtriplett commented on Apr 26, 2022

@joshtriplett
Member

That would be a fast stabilization, but given that they're rather simple types, that seems potentially reasonable.

Mark-Simulacrum

Mark-Simulacrum commented on Apr 26, 2022

@Mark-Simulacrum
MemberAuthor

If we were to stabilize, presumably we'd do that on master and back out the PR from beta? I am reluctant to backport a stabilization to fix this (particularly a fast one, as you mention).

removed
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Apr 26, 2022
joshtriplett

joshtriplett commented on Apr 27, 2022

@joshtriplett
Member

@Mark-Simulacrum Yeah, reverting the PR on beta seems fine for now.

added a commit that references this issue on Apr 29, 2022

Rollup merge of rust-lang#96492 - joshtriplett:revert-std-ffi-re-expo…

9b2452e

8 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-libsRelevant to the library team, which will review and decide on the PR/issue.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @joshtriplett@dtolnay@Mark-Simulacrum@petrochenkov@rustbot

      Issue actions

        [regression] ambiguity libc/ffi/os::raw for c_ types · Issue #96435 · rust-lang/rust