Skip to content

Move check-bootstrap from a makefile rule to test::Bootstrap #96688

Closed
@jyn514

Description

@jyn514
Member

It's very confusing that this can't actually be run through x.py itself; it tripped me up in #96687.

See

check-bootstrap:
$(Q)$(CFG_PYTHON) $(CFG_SRC_DIR)src/bootstrap/bootstrap_test.py
for the existing code and

rust/src/bootstrap/test.rs

Lines 2349 to 2355 in 1b2e0b6

impl Step for Bootstrap {
type Output = ();
const DEFAULT: bool = true;
const ONLY_HOSTS: bool = true;
/// Tests the build system itself.
fn run(self, builder: &Builder<'_>) {
for where it should be moved.

@rustbot label +A-rustbuild +E-easy +E-mentor +E-help-wanted +A-contributor-roadblock

Activity

added
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to Rust
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-help-wantedCall for participation: Help is requested to fix this issue.
E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
on May 4, 2022
ghost

ghost commented on May 4, 2022

@ghost

@rustbot claim

added a commit that references this issue on May 8, 2022

Auto merge of rust-lang#96689 - gimbles:campfire, r=Mark-Simulacrum

8fbd92d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-help-wantedCall for participation: Help is requested to fix this issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @jyn514@rustbot

      Issue actions

        Move `check-bootstrap` from a makefile rule to `test::Bootstrap` · Issue #96688 · rust-lang/rust