-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
Bootstrap is unfortunately quite inconsistent about which it uses currently :(
$ rg -g '!build.rs' println src/bootstrap/ | grep -v eprintln | wc -l
88
$ rg eprintln src/bootstrap/ | wc -l
60
stderr probably makes more sense? but I don't know when someone would look at just stdout or just stderr; having a hard time imagining use cases.
cc @bjorn3
Originally posted by @jyn514 in #96687 (comment)
Metadata
Metadata
Assignees
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
bjorn3 commentedon May 4, 2022
For example
./x.py test >test_log.txt
would show warnings on the terminal as stderr is not redirected but put the results of all tests in test_log.txt. Not that I can recall every doing something like that, but it could be useful I guess.jyn514 commentedon May 4, 2022
Sure, seems fine. Let's use eprintln consistently then.
@rustbot label +E-easy +A-rustbuild
raiyansayeed commentedon May 5, 2022
@rustbot claim
[-]Decide whether to print to stdout or stderr in bootstrap[/-][+]Print to stderr consistently in bootstrap[/+]lionellloh commentedon May 25, 2022
@raiyansayeed are you still working on this?
raiyansayeed commentedon May 25, 2022
Hey yes I'm still working on it, have most of it implemented I think. I just haven't gotten the time to review my code / push, although I think I should be able to do it by the end of this week.
Rollup merge of rust-lang#97411 - raiyansayeed:print-stderr-consisten…
jyn514 commentedon Jun 20, 2022
Looks like this was done in #97411, thanks!