Skip to content

x build src/tools/miri doesn't install miri as part of the built toolchain #97762

Closed
@Kixiron

Description

@Kixiron
Member

Running x build src/tools/miri doesn't include miri as part of the built rust toolchain, meaning that cargo +custom-toolchain miri doesn't work

cc @jyn514

Activity

Kixiron

Kixiron commented on Jun 5, 2022

@Kixiron
MemberAuthor

@rustbot label +A-rustbuild

added
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
on Jun 5, 2022
WaffleLapkin

WaffleLapkin commented on Jun 30, 2022

@WaffleLapkin
Member

It seems like the same thing happens to rustfmt: x b rustfmt doesn't include rustfmt as part of the built rust toolchain, meaning that rustfmt +custom-toolchain doesn't work.

daxpedda

daxpedda commented on Jul 23, 2022

@daxpedda
Contributor

The same thing applies to cargo and clippy.

jyn514

jyn514 commented on Jul 23, 2022

@jyn514
Member

We need to call add_to_sysroot in all of these steps. I think that currently adds all libraries as well which isn't correct - someone should look into how this is done for rustdoc and do the same for the other tools. Take a look around src/bootstrap/compile.rs.

I agree it's a bug that we don't copy these today.

added
E-help-wantedCall for participation: Help is requested to fix this issue.
E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.
on Jul 23, 2022
WaffleLapkin

WaffleLapkin commented on Sep 18, 2022

@WaffleLapkin
Member

@rustbot claim

Emilgardis

Emilgardis commented on Oct 2, 2022

@Emilgardis
Contributor

this seems related to #81431

onur-ozkan

onur-ozkan commented on Apr 11, 2023

@onur-ozkan
Member

@rustbot claim

added a commit that references this issue on Apr 21, 2023

Rollup merge of rust-lang#110365 - ozkanonur:ship-tools-with-sysroot,…

f2321ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.E-help-wantedCall for participation: Help is requested to fix this issue.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @Emilgardis@daxpedda@jyn514@Kixiron@WaffleLapkin

    Issue actions

      `x build src/tools/miri` doesn't install miri as part of the built toolchain · Issue #97762 · rust-lang/rust