Skip to content

Links in deprecated notes have poor contrast #98341

Closed
@jplatte

Description

@jplatte
Contributor

I tried documenting this code:

#[deprecated = "Replaced by [`Client::login_token`](#method.login_token)"]
pub async fn login_with_token(
    // ...

I expected to see this happen: cargo doc generating a beautiful doc page

Instead, this happened:

Screenshot_2022-06-21_154838

Meta

rustc --version --verbose:

rustc 1.63.0-nightly (cacc75c82 2022-06-16)
binary: rustc
commit-hash: cacc75c82ebe15cf63d31034fcf7f1016cddf0e2
commit-date: 2022-06-16
host: x86_64-unknown-linux-gnu
release: 1.63.0-nightly
LLVM version: 14.0.5

@rustbot labels: +T-rustdoc +A-rustdoc-ui

Activity

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
A-rustdoc-uiArea: Rustdoc UI (generated HTML)
on Jun 21, 2022
fmease

fmease commented on Dec 28, 2024

@fmease
Member

Triage: Rendering today:

Image

fmease

fmease commented on Dec 28, 2024

@fmease
Member

I think we can close this issue though I wonder if we want to have a GUI test for this if we don't have one already

GuillaumeGomez

GuillaumeGomez commented on Dec 28, 2024

@GuillaumeGomez
Member

I'll add one.

jplatte

jplatte commented on Dec 28, 2024

@jplatte
ContributorAuthor

Contrast is okay-ish now but I think it would look considerably better witht the same color as text, only underlined. May be personal taste. Extra weird though that ayu has the underline in a different color from the link text.

added a commit that references this issue on Dec 31, 2024

Rollup merge of rust-lang#134861 - GuillaumeGomez:item-info-colors, r…

7870003
added a commit that references this issue on Dec 31, 2024

Rollup merge of rust-lang#134861 - GuillaumeGomez:item-info-colors, r…

63d5b72
added a commit that references this issue on Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-uiArea: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.L-deprecatedLint: deprecatedT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @jplatte@GuillaumeGomez@fmease@rustbot

      Issue actions

        Links in deprecated notes have poor contrast · Issue #98341 · rust-lang/rust