Skip to content

False positive on non_exhaustive_omitted_patterns_lint with closures #99815

Closed
@Nemo157

Description

@Nemo157
Member

I tried this code (playground):

#![warn(non_exhaustive_omitted_patterns)]

// in other library:
// #[non_exhaustive] pub enum Foo { A, B }
use lib::Foo;

fn foo(_: impl Fn(Foo)) {}

fn main() {
    foo(|_: Foo| { todo!() });
}

I expected to see this happen: no warnings.

Instead, this happened:

warning: some variants are not matched explicitly
  --> src/main.rs:10:14
   |
10 |         foo(|_: Foo| { todo!() });
   |              ^ patterns `A` and `B` not covered
   |

Meta

1.64.0-nightly (2022-07-26 4d6d601c8a83284d6b23)

cc #89554

Activity

Nemo157

Nemo157 commented on Jul 27, 2022

@Nemo157
MemberAuthor

(Note: it's not to do with the _ pattern, in the real code I found this in the argument was used).

Mark-Simulacrum

Mark-Simulacrum commented on Jul 27, 2022

@Mark-Simulacrum
Member

I think this is a good thing to fix, but I don't think this would block stabilization since:

  • It's unlikely you're enabling the lint across an entire crate -- most of the time, it'll be limited to a few tests or specific matches, probably.
  • The lint can be fixed in the future (we should definitely do that though!)
added a commit that references this issue on Apr 2, 2023

Auto merge of rust-lang#109836 - clubby789:param-non-exhaustive, r=Ni…

f5f93d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @Nemo157@Mark-Simulacrum

      Issue actions

        False positive on `non_exhaustive_omitted_patterns_lint` with closures · Issue #99815 · rust-lang/rust