fix: add cfg diagnostic for unresolved import error #112854
Merged
+71
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Noratrieb
reviewed
Jun 20, 2023
sladyn98
reviewed
Jun 21, 2023
Noratrieb
reviewed
Jun 24, 2023
There was a problem hiding this comment.
could you add one more test for
pub use b::{x,y};
//~^ ERROR unresolved imports `b::x`, `b::y`
//~| NOTE no `x` in `b`
//~| NOTE no `y` in `b`
mod b {
#[cfg(no)]
pub fn x() {}
//~^ NOTE found an item that was configured out
#[cfg(no)]
pub fn y() {}
//~^ NOTE found an item that was configured out
}r=me aftwerwards
|
@bors delegate+ |
|
✌️ @bvanjoi, you can now approve this pull request! If @Nilstrieb told you to " |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2023
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#112703 ([-Ztrait-solver=next, mir-typeck] instantiate hidden types in the root universe) - rust-lang#112854 (fix: add cfg diagnostic for unresolved import error) - rust-lang#112912 (style-guide: Rewrite let-else section for clarity, without changing formatting) - rust-lang#112915 (Update runtests.py : grammar correction) - rust-lang#112971 (issue template: add clippy entry which points to the clippy repo) - rust-lang#112989 (Add a regression test for rust-lang#109141) - rust-lang#113002 (bootstrap: Backup `settings.json` to the correct filename) - rust-lang#113003 (Fix old python deprecation check in x.py) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112674
An easy fix, r? @Nilstrieb