Skip to content

Add codegen test to guard against VecDeque optimization regression #116047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

a-lafrance
Copy link
Contributor

Very small PR that adds a codegen test to guard against regression for the VecDeque optimization addressed in #80836. Ensures that Rustc optimizes away the panic when unwrapping the result of .get(0) because of the !is_empty() condition.

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2023
@a-lafrance a-lafrance changed the title Add test to guard against VecDeque optimization regression Add codegen test to guard against VecDeque optimization regression Sep 22, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 23, 2023

📌 Commit d5ec9af has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2023
@bors
Copy link
Collaborator

bors commented Sep 23, 2023

⌛ Testing commit d5ec9af with merge 19c6502...

@bors
Copy link
Collaborator

bors commented Sep 23, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 19c6502 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 23, 2023
@bors bors merged commit 19c6502 into rust-lang:master Sep 23, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 23, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (19c6502): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.954s -> 634.731s (-0.04%)
Artifact size: 317.84 MiB -> 317.81 MiB (-0.01%)

@a-lafrance a-lafrance deleted the I80836-codegen-test branch September 24, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants