Skip to content

Clean dead codes in miri #118399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023
+0 −26
Merged

Clean dead codes in miri #118399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/tools/miri/src/shims/unix/fs.rs
View file
Original file line number Diff line number Diff line change
@@ -66,11 +66,6 @@ pub trait FileDescriptor: std::fmt::Debug + Any {
fn is_tty(&self, _communicate_allowed: bool) -> bool {
false
}

#[cfg(unix)]
fn as_unix_host_fd(&self) -> Option<i32> {
None
}
}

impl dyn FileDescriptor {
@@ -150,12 +145,6 @@ impl FileDescriptor for FileHandle {
Ok(Box::new(FileHandle { file: duplicated, writable: self.writable }))
}

#[cfg(unix)]
fn as_unix_host_fd(&self) -> Option<i32> {
use std::os::unix::io::AsRawFd;
Some(self.file.as_raw_fd())
}

fn is_tty(&self, communicate_allowed: bool) -> bool {
communicate_allowed && self.file.is_terminal()
}
@@ -183,11 +172,6 @@ impl FileDescriptor for io::Stdin {
Ok(Box::new(io::stdin()))
}

#[cfg(unix)]
fn as_unix_host_fd(&self) -> Option<i32> {
Some(libc::STDIN_FILENO)
}

fn is_tty(&self, communicate_allowed: bool) -> bool {
communicate_allowed && self.is_terminal()
}
@@ -220,11 +204,6 @@ impl FileDescriptor for io::Stdout {
Ok(Box::new(io::stdout()))
}

#[cfg(unix)]
fn as_unix_host_fd(&self) -> Option<i32> {
Some(libc::STDOUT_FILENO)
}

fn is_tty(&self, communicate_allowed: bool) -> bool {
communicate_allowed && self.is_terminal()
}
@@ -250,11 +229,6 @@ impl FileDescriptor for io::Stderr {
Ok(Box::new(io::stderr()))
}

#[cfg(unix)]
fn as_unix_host_fd(&self) -> Option<i32> {
Some(libc::STDERR_FILENO)
}

fn is_tty(&self, communicate_allowed: bool) -> bool {
communicate_allowed && self.is_terminal()
}