Skip to content

Conversation

zmodem
Copy link
Contributor

@zmodem zmodem commented May 24, 2024

They are no longer supported by LLVM 19.

Fixes #125492

@rustbot
Copy link
Collaborator

rustbot commented May 24, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2024

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in tests/ui/check-cfg

cc @Urgau

@zmodem
Copy link
Contributor Author

zmodem commented May 24, 2024

cc @durin42 @krasimirgg

Can someone add the llvm-main label please?

@durin42
Copy link
Contributor

durin42 commented May 24, 2024

@rustbot +llvm-main

@durin42
Copy link
Contributor

durin42 commented May 24, 2024

@rustbot label llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label May 24, 2024
@rust-log-analyzer

This comment has been minimized.

@workingjubilee
Copy link
Member

Squash please.

r? @workingjubilee

@rustbot rustbot assigned workingjubilee and unassigned cjgillot May 24, 2024
@workingjubilee
Copy link
Member

You need to pingback the AVX512 features tracking issue which tracks these as unstable.

@workingjubilee
Copy link
Member

You need to pingback the AVX512 features tracking issue which tracks these as unstable.

it is possible this does not exist, which would be annoying.

They are no longer supported by LLVM 19.

Fixes rust-lang#125492
@zmodem
Copy link
Contributor Author

zmodem commented May 24, 2024

Squash please.

Done.

You need to pingback the AVX512 features tracking issue which tracks these as unstable.

I didn't find one. (But I'm also a newbie here, and not completely sure what I'm looking for..)

@workingjubilee
Copy link
Member

these features should have been tracked by #111137 or there should have been another tracking issue for them.

@workingjubilee
Copy link
Member

It looks like it simply had gone untracked, which isn't your fault.

If LLVM is planning on dropping any other features on the avx512 target feature list here, then letting us know on that tracking issue would be good before we stabilize anything. But this can simply be dropped without notice as it's behind a nightly feature.

@bors r+

@bors
Copy link
Collaborator

bors commented May 24, 2024

📌 Commit 3fe3157 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request May 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Stop using the avx512er and avx512pf x86 target features

They are no longer supported by LLVM 19.

Fixes rust-lang#125492
@bors bors merged commit 4d13c96 into rust-lang:master May 25, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
8 participants